Add docstrings to the RPC folder#676
Merged
Merged
Conversation
auto-assign
Bot
requested review from
RyRy79261,
juans-chainsafe,
kantagara,
oleksandrchainsafe,
robGG1997 and
sneakzttv
RyRy79261
approved these changes
Oct 24, 2023
Contributor
RyRy79261
left a comment
RyRy79261
left a comment
There was a problem hiding this comment.
Looks good, though I'm not sure if we might want to expand on certain definitions, like in the context of the Contract class, where we could say more for jargon heavy topics like, ABI, Calldata, Gas, Estimates, etc
Member
Author
|
@RyRy79261 I agree with you completely. The only reason I hesitated is that we still do not have clear strategy on the general purpose smart contracts. I think that can be improved as soon as we start tackling this part. |
robGG1997
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Add comments to the RPC folder * Auto-duplicate Package Samples * retrigger checks --------- Co-authored-by: kalambet <kalambet@users.noreply.github.com>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Add comments to the RPC folder * Auto-duplicate Package Samples * retrigger checks --------- Co-authored-by: kalambet <kalambet@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Add comments to the RPC folder * Auto-duplicate Package Samples * retrigger checks --------- Co-authored-by: kalambet <kalambet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #667